----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review149932 -----------------------------------------------------------
Fix it, then Ship it! i'll fix the typos while committing. src/tests/command_executor_tests.cpp (line 260) <https://reviews.apache.org/r/52075/#comment217717> s/short/short lived/ src/tests/command_executor_tests.cpp (line 279) <https://reviews.apache.org/r/52075/#comment217716> s/the// - Vinod Kone On Sept. 20, 2016, 3:22 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52075/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 3:22 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5276 > https://issues.apache.org/jira/browse/MESOS-5276 > > > Repository: mesos > > > Description > ------- > > Added the test `HTTPCommandExecutorTest.TerminateWithACK`. > > > Diffs > ----- > > src/slave/slave.hpp 13c76d1eaea2b49519948c9116e5db5caf9407ea > src/tests/command_executor_tests.cpp > 07e5eb4d7c2ace2b6714fbe02f29d41663152556 > src/tests/mock_slave.hpp 53e1c9ee1ae5150fc2e6deebb574c9c86e08df7f > > Diff: https://reviews.apache.org/r/52075/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >