----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/#review150192 -----------------------------------------------------------
(1) Is it possible to narrow the warning disabling statements like this? ``` #ifdef __WINDOWS__ #pragma warning(disable:4146) #endif result = -result; #ifdef __WINDOWS__ #pragma warning(default:4146) #endif ``` (2) Could just leave a short comment around the reason for turning off this warning at this specific spot? - Michael Park On Sept. 23, 2016, 4:46 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52062/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 4:46 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > When the template is instatiated for unsigned scalars > the unary negation generates warnings. > > > Diffs > ----- > > 3rdparty/stout/include/stout/numify.hpp > c174fcb8cb9d809f443e44058f07b58751bed9dd > > Diff: https://reviews.apache.org/r/52062/diff/ > > > Testing > ------- > > Windows: build > > > Thanks, > > Daniel Pravat > >