----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review150291 -----------------------------------------------------------
include/mesos/resources.hpp (lines 179 - 213) <https://reviews.apache.org/r/51999/#comment218188> We would need to call these APIs from `Containerizer` for parsing of `flags.resources` so I do not think we can `private` these APIs. src/common/resources.cpp (line 670) <https://reviews.apache.org/r/51999/#comment218189> I am not sure I understand your concern. In `fromJsonString()` [actually `convertJson()`] and `fromSimpleString()`, individual `Resource` object is validated. In `Resources::parse()`, we call `internal::validateCommandLineResources(resources)` to check for dynamic reservation, persistent volume, etc. Secondly, what are you implying by `role` validation? Would you please elaborate? - Anindya Sinha On Sept. 26, 2016, 6:46 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51999/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 6:46 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Refactored `Resources::parse()` into 2 separate static functions: > 1. Resources::fromJSONString() to parse JSON representation of > resources. > 2. Resources::fromSimpleString() to parse text representation of > resources. > > Since these 2 new functions return a `Try<vector<Resource>>`, the > existing `Resources::parse()` implicitly converts that to a > `Resources` object. This refactor is done to retrieve all resources > (include empty resources) required for auto detection of root > and MOUNT disks. > > > Diffs > ----- > > include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 > include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 > src/common/resources.cpp 0774ff0669e831494d5b12b88e19dfa0a4a3f757 > src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a > src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90 > > Diff: https://reviews.apache.org/r/51999/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
