----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review151126 -----------------------------------------------------------
src/common/resources.cpp (lines 857 - 860) <https://reviews.apache.org/r/52002/#comment219271> I think we should kill this as we already have the validation in `isRootDisk` and the resource will always have disk source at here. src/tests/resources_tests.cpp (line 2182) <https://reviews.apache.org/r/52002/#comment219272> Here we should keep 4 space start from the `(` above or else you can: ``` ASSERT_TRUE( Resources::isRootDisk( createDiskResource("100", "role1", None(), None()))); ``` Ditto for others which has two `(` in one line. - Guangya Liu On 九月 28, 2016, 7:24 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52002/ > ----------------------------------------------------------- > > (Updated 九月 28, 2016, 7:24 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Added helper methods to determine types of disk resources. > > > Diffs > ----- > > include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 > include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 > src/common/resources.cpp 0774ff0669e831494d5b12b88e19dfa0a4a3f757 > src/tests/resources_tests.cpp 3e493007d6d1d8194d07035aaa1cde28dedf2b5a > src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90 > > Diff: https://reviews.apache.org/r/52002/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
