----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151394 -----------------------------------------------------------
src/tests/health_check_tests.cpp (lines 1169 - 1172) <https://reviews.apache.org/r/52432/#comment219711> Why do you check twice for the same thing? Do you want to check for TASK_RUNNING? - Alexander Rukletsov On Sept. 30, 2016, 6:12 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52432/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 6:12 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > This test was disabled in 2014 because it was considered flaky. I > updated it so that it runs quicker and ran it 1000 times without a > single failure. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52432/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --verbose --gtest_filter="HealthCheckTest.GracePeriod" > --break-on-error --gtest_repeat=1000 > > > Thanks, > > Gastón Kleiman > >
