> On Oct. 5, 2016, 10:35 a.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, lines 1169-1170 > > <https://reviews.apache.org/r/52432/diff/2/?file=1516957#file1516957line1169> > > > > Should be > > > > ``` > > AWAIT_READY(statusRunning); > > EXPECT_EQ(TASK_RUNNING, statusRunning.get().state()); > > ``` > > > > here.
Thanks! I rewrote these assertions, please take another look =). - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52432/#review151483 ----------------------------------------------------------- On Oct. 5, 2016, 12:37 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52432/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 12:37 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Repository: mesos > > > Description > ------- > > This test was disabled in 2014 because it was considered flaky. I > updated it and ran it 1000 times without a single failure. > > > Diffs > ----- > > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52432/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --verbose --gtest_filter="HealthCheckTest.GracePeriod" > --break-on-error --gtest_repeat=1000 > > > Thanks, > > Gastón Kleiman > >
