----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/#review152047 -----------------------------------------------------------
Ship it! LGTM modulo naming of "metrics_singleton" - Vinod Kone On Sept. 20, 2016, 12:41 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40411/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 12:41 a.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, > and Vinod Kone. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > Updates the test's reference to the global metrics singleton. > > > Diffs > ----- > > src/tests/scheduler_driver_tests.cpp > faf2e6c8ad17e07964b4340d0b340654b03f9086 > src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 > > Diff: https://reviews.apache.org/r/40411/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > >
