----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/#review152048 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/reap.hpp (line 54) <https://reviews.apache.org/r/40413/#comment220756> s/reaper_singleton/reaper/ 3rdparty/libprocess/include/process/reap.hpp (line 57) <https://reviews.apache.org/r/40413/#comment220755> new line. 3rdparty/libprocess/src/reap.cpp (line 150) <https://reviews.apache.org/r/40413/#comment220760> new line. 3rdparty/libprocess/src/reap.cpp (line 154) <https://reviews.apache.org/r/40413/#comment220762> you do initilialize here but not in metrics process? - Vinod Kone On Aug. 10, 2016, 8:17 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40413/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 8:17 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, > and Vinod Kone. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > The reaper singleton must be unified with `process::initialize` so > that it also falls under the scope of reinitialization. The singleton > must also not be guarded by `Once`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp > d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee > 3rdparty/libprocess/src/process.cpp > 629f1644bc0a263972ec9efc41890c33f9406a34 > 3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a > > Diff: https://reviews.apache.org/r/40413/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > >
