----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/#review152427 -----------------------------------------------------------
src/linux/fs.cpp (line 145) <https://reviews.apache.org/r/51620/#comment221434> If you remove the `std::move()`, then you can remove this temporary variable reference. - Kevin Klues On Sept. 3, 2016, 12:25 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51620/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2016, 12:25 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-6118 > https://issues.apache.org/jira/browse/MESOS-6118 > > > Repository: mesos > > > Description > ------- > > Since 'entry' is a const reference, the std::move won't reduce the > extra copying. This patch removed this optimization. > > > Diffs > ----- > > src/linux/fs.cpp 14ae5a9089916549f691363bc2269e13c5260a14 > > Diff: https://reviews.apache.org/r/51620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
