> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > <https://reviews.apache.org/r/50128/diff/10/?file=1507914#file1507914line95> > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: > This function is also used by another fix in `src/docker/docker.cpp`. I > prefer to leave it here because if we move it, this patch only adds `<<` > function and seems a little strange. Your opinion? > > Guangya Liu wrote: > Which fix depend on it? Why cannot move it to /r/50125 ? > > Yubo Li wrote: > Yes, we can move it to `/r/50125`. If we do this, I suggest to merge this > patch to `/r/50125` directly, because here is only `<<` function remained in > this patch, how do you think?
There is no problem now. - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review151937 ----------------------------------------------------------- On 十月 11, 2016, 8:16 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 十月 11, 2016, 8:16 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions to 'Docker::Device' to handle data > parsing and serializing between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
