----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review152638 -----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp (lines 3958 - 3959) <https://reviews.apache.org/r/50127/#comment221743> I think that the comments should be updated to hightlight that the docker contianer running in priviledged mode will get all GPU resources, so here we need to make sure that the container is running in non-priviledged mode so as to let the gpu allocator to allocate GPU resources. ``` // Docker container running in priviledged will get all GPU resources // from the GPU server and the GPU resources will not be allocated by // the GPU allocator, so here we need to make sure that the docker // container is running in non-priviledged mode so as to make sure the // GPU resources are allocated by the GPU allocator. EXPECT_SOME_FALSE(find); ``` src/tests/containerizer/docker_containerizer_tests.cpp (lines 3991 - 3993) <https://reviews.apache.org/r/50127/#comment221748> s/EXPECT_EQ/EXPECT_TRUE - Guangya Liu On 十月 11, 2016, 8:30 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50127/ > ----------------------------------------------------------- > > (Updated 十月 11, 2016, 8:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added a testing case for end-to-end GPU support for docker > containerizer. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a > > Diff: https://reviews.apache.org/r/50127/diff/ > > > Testing > ------- > > GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j > check > > > Thanks, > > Yubo Li > >
