----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153282 -----------------------------------------------------------
Fix it, then Ship it! src/linux/cgroups.hpp (lines 214 - 215) <https://reviews.apache.org/r/51031/#comment222621> s/all the cgroups/all the child cgroups/ src/linux/cgroups.cpp (line 851) <https://reviews.apache.org/r/51031/#comment222613> Here it's not necessary. We are checking if we have **ANY** decendants so just the children would do. src/linux/cgroups.cpp (lines 915 - 918) <https://reviews.apache.org/r/51031/#comment222560> Move this whole paragraph to be above `FTSENT* node;`? The comment is really for the whole block, including logic in the while condition. Leave `// Skip traversing the subtree if not recursive.` here. src/linux/cgroups.cpp (line 919) <https://reviews.apache.org/r/51031/#comment222561> How about ``` Skip traversing at the children level if not recursive. ``` ? src/tests/containerizer/cgroups_tests.cpp (lines 417 - 427) <https://reviews.apache.org/r/51031/#comment222622> Do we actually need to remove them (since this is "ROOT_CGROUPS_RecursiveGet")? src/tests/containerizer/cgroups_tests.cpp (lines 468 - 478) <https://reviews.apache.org/r/51031/#comment222623> Ditto. - Jiang Yan Xu On Oct. 19, 2016, 8:45 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 8:45 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > In most cases, we just want to get the children cgroups instead of > retrieve descendant cgroups recursively. We added an argument to > `cgroups::get` to indicate whether retrieve cgroups recursively and > make non-recursive retrieve become the default behaviour. This patch > fixed some incorrect `TEST_CGROUPS_ROOT` checks as well. > > > Diffs > ----- > > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d > src/tests/containerizer/cgroups_tests.cpp > 0afaec6ae948cabf1472bf01103210d8f9809cb1 > src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
