> On Oct. 20, 2016, 1:50 p.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 412 > > <https://reviews.apache.org/r/51031/diff/14/?file=1541970#file1541970line412> > > > > Who remove the cgroup created above?
Hmm, the intention is to have them destroyed in teardown but I guess these cgroups don't start with `TEST_CGROUPS_ROOT`. I'll add back these removal lines and we can think about how to do auto-cleanup better. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153455 ----------------------------------------------------------- On Oct. 20, 2016, 10:38 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 10:38 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and > Jiang Yan Xu. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > In most cases, we just want to get the children cgroups instead of > retrieve descendant cgroups recursively. We added an argument to > `cgroups::get` to indicate whether retrieve cgroups recursively and > make non-recursive retrieve become the default behaviour. This patch > fixed some incorrect `TEST_CGROUPS_ROOT` checks as well. > > > Diffs > ----- > > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d > src/tests/containerizer/cgroups_tests.cpp > 0afaec6ae948cabf1472bf01103210d8f9809cb1 > src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
