> On Oct. 20, 2016, 9:55 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 1501 > > <https://reviews.apache.org/r/53047/diff/1/?file=1542099#file1542099line1501> > > > > This test case would not go through `parse()` method. Since we only use > > state to construct the `Container` then put it in `containers_` directly > > which would bypass `parse`. > > > > > > ``` > > // Create and store a container. > > Container* container = new Container(containerId); > > containers_[containerId] = container; > > container->slaveId = state->id; > > container->state = Container::RUNNING; > > container->launchesExecutorContainer = > > executorContainers.contains(containerId); > > ```
I will work on changing the testcase such that it goes through the parse() method. Will update soon - Manuwela ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153374 ----------------------------------------------------------- On Oct. 20, 2016, 11:46 a.m., Manuwela Kanade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53047/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 11:46 a.m.) > > > Review request for mesos, haosdent huang, Timothy Chen, and Vinod Kone. > > > Bugs: MESOS-6212 > https://issues.apache.org/jira/browse/MESOS-6212 > > > Repository: mesos > > > Description > ------- > > MESOS-6212: name format validation for mesos managed docker containers. > > > Diffs > ----- > > 3rdparty/stout/tests/uuid_tests.cpp > fe9894af93df9cb9b12390d8d7e7885525db384d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > src/tests/containerizer/docker_containerizer_tests.cpp > 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a > > Diff: https://reviews.apache.org/r/53047/diff/ > > > Testing > ------- > > 1. Ran the "make check" > > 2. Manual Testing done as below: > Testing without changes: Created and ran an example container which is not > run using mesos : named "mesos-rsyslog" which got killed once mesos-agent > started with --containerizer=docker,mesos. > > Testing with changes: Created and ran an example container (not run using > mesos): named "mesos-rsyslog" which keeps running and mesos-agent does not > kill it thus avoiding the false positive > > > Thanks, > > Manuwela Kanade > >
