----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53084/#review154028 -----------------------------------------------------------
src/launcher/default_executor.cpp (line 1033) <https://reviews.apache.org/r/53084/#comment223547> Shouldn't we be using a guarding `#ifdef` to make sure we are not allowing HTTPS on non SSL builds? src/launcher/default_executor.cpp (line 1036) <https://reviews.apache.org/r/53084/#comment223546> Nice, thanks for adding the tracking ticket. - Till Toenshoff On Oct. 27, 2016, 3:49 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53084/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 3:49 p.m.) > > > Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till > Toenshoff, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > `LIBPROCESS_SSL_ENABLED` is preferred over `SSL_ENABLED`, and the latter > will be deprecated soon. > > > Diffs > ----- > > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d > > Diff: https://reviews.apache.org/r/53084/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
