> On 十一月 1, 2016, 3:19 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 756 > > <https://reviews.apache.org/r/50128/diff/20/?file=1550713#file1550713line756> > > > > I think that we actually need to check invalid permissions here, as it > > is possible that there are invalid permissions when create container. But > > agree that we can handle this in a separate patch.
Sure - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154409 ----------------------------------------------------------- On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
