> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/docker/docker.cpp, line 388 > > <https://reviews.apache.org/r/50128/diff/17/?file=1543832#file1543832line388> > > > > Add an error here to verify correct set of permissions in the > > permissions field. > > > > Once we have done all of this validation, we know it is safe to set the > > fields as we do below without error. > > Guangya Liu wrote: > This is only called after `docker inspect`, so I think that there will be > no error field in the permission field? But adding a check here will not > impact much.
I think we could put it to another patch. - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review153838 ----------------------------------------------------------- On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
