> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am, line 120 > > <https://reviews.apache.org/r/52645/diff/7/?file=1550864#file1550864line120> > > > > Not sure we want to remove the existing `-Werror`.
>From a discussion with a few people on Slack it sounded like this was in the >wrong place to begin with (along with `-Wall` and `-Wsign-compare`). I found >that when I had moved this to `AM_CXXFLAGS` it would actually apply hard >errors for warnings where it never did before. The issue now with putting this >back into `AM_CXXFLAGS` is that all of the `clang: error: argument unused >during compilation: '-pthread'` warnings you get when building Mesos which >were always there now fail the whole thing. I think we'd have to unravel the >overall build process more to fix that issue. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review154524 ----------------------------------------------------------- On Nov. 1, 2016, 7:37 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 7:37 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > Mesos. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > configure.ac c8d48be > m4/ax_check_compile_flag.m4 PRE-CREATION > src/Makefile.am c2f9e44 > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
