----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ -----------------------------------------------------------
(Updated Nov. 7, 2016, 9:25 p.m.) Review request for mesos, James Peach, Michael Park, and Neil Conway. Changes ------- Addressed comments, added a new flag to enable/disable hardening, apply hardening by default. Bugs: MESOS-6229 https://issues.apache.org/jira/browse/MESOS-6229 Repository: mesos Description ------- Use a default set of flags to provide additional security and hardening to Mesos. Additionally, check and catch more warnings/errors. Diffs (updated) ----- configure.ac 5380cbc m4/ax_check_compile_flag.m4 PRE-CREATION src/Makefile.am 5a47c93 Diff: https://reviews.apache.org/r/52645/diff/ Testing ------- Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower. Thanks, Aaron Wood