> On Nov. 4, 2016, 2:41 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 36-37 > > <https://reviews.apache.org/r/53435/diff/1/?file=1553266#file1553266line36> > > > > I am unsure what style is preferred here. We could (a) order header > > groups by directory depth (that's e.g., the reason > > `slave/containerizer/mesos/linux_launcher.hpp` is on l.29, not below l.36, > > or (b) keep related headers together. I can see both patterns in the code > > base. Maybe you have an idea. > > Neil Conway wrote: > I'd prefer the former (sort by directory depth, then lexicographically). > > Benjamin Bannier wrote: > In that case you should move `#include > "slave/containerizer/mesos/isolators/filesystem/linux.hpp"` just below > `#include "slave/containerizer/mesos/isolators/docker/runtime.hpp"` (with a > newline).
Sorry: I meant something like: ``` #include "a.hpp" #include "b.hpp" #include "a/c.hpp" #include "a/d.hpp" #include "a/c/e.hpp" #include "a/d/f.hpp" ``` - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53435/#review154904 ----------------------------------------------------------- On Nov. 4, 2016, 3:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53435/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 3:15 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed header include order. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > ca7bffd3b1773a11a4679d114885d3edd977b02b > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > > Diff: https://reviews.apache.org/r/53435/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
