> On Nov. 4, 2016, 4:06 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, lines 36-37 > > <https://reviews.apache.org/r/53435/diff/1/?file=1553266#file1553266line36> > > > > That's what I understood, but I made an error in my comment: in that > > ordering it should be at the same level as `runtime.hpp` since both of > > these a 6 levels deep. Currently `linux.hpp` is preceeded by headers 7 > > levels deep. > > > > I seems this ruleis rather complicated in pratice.
Yeah, there are a lot of corner cases. Personally I think this isn't worth devoting a lot of attention to in the absence of tool support. I'd personally vote for (a) coming up with a reasonable sort order (b) once we get consensus, add that to the style guide (c) writing a clang-tidy check that implements the sort order. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53435/#review154925 ----------------------------------------------------------- On Nov. 4, 2016, 3:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53435/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 3:15 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed header include order. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > ca7bffd3b1773a11a4679d114885d3edd977b02b > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > > Diff: https://reviews.apache.org/r/53435/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
