----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/#review154994 -----------------------------------------------------------
Ship it! LGTM :) - Joseph Wu On Nov. 3, 2016, 9:23 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53387/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 9:23 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > `clang-tidy` rightly points out that certain `ASSERT` failures can > result in leaking some heap-allocated values that aren't wrapped in a > smart pointer. This commit fixes the cases that `clang-tidy` complains > about by wrapping the values in `Owned<T>`. > > Note that there are many other places in the tests that leak resources > if an exception occurs. The proper fix is usually to use a smart pointer > rather than a raw pointer; several of these APIs should be changed to > return Owned<T>, for example. However, this is not always easy/clean, in > part because of limitations of the current `Owned<T>` and `Shared<T>` > types (e.g., MESOS-5122, MESOS-6496). So for now, just fix the cases > that clang-tidy complains about and a few other similar instances. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > ca7bffd3b1773a11a4679d114885d3edd977b02b > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > > Diff: https://reviews.apache.org/r/53387/diff/ > > > Testing > ------- > > `make check` > > Verified that observed `clang-tidy` warnings go away with this change. > > > Thanks, > > Neil Conway > >
