----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/ -----------------------------------------------------------
Review request for mesos and Joseph Wu. Repository: mesos Description ------- `clang-tidy` points out, rightly, that an `ASSERT` failure can result in leaking some heap-allocated values that aren't wrapped in a smart pointer. This commit fixes the cases that `clang-tidy` complains about by wrapping the values in `Owned<T>`. Note that there are many other places in the tests that leak resources if an exception occurs. The proper fix is usually to use a smart pointer rather than a raw pointer. However, this is not always easy/clean, in part because the current `Owned<T>` and `Shared<T>` types do not support inheritance (MESOS-6496). So for now, just fix the cases that clang-tidy complains about. Diffs ----- src/tests/containerizer/mesos_containerizer_tests.cpp 4df537747d84daa68c29e2d05b22fa386a4a16db Diff: https://reviews.apache.org/r/53387/diff/ Testing ------- `make check` Verified that observed `clang-tidy` warnings go away with this change. Thanks, Neil Conway
