----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53623/#review155541 -----------------------------------------------------------
Patch looks great! Reviews applied: [53623] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 10, 2016, 12:38 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53623/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 12:38 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > The provisioner's `copy` backend has never been supported on Windows, > but we have included it in the build to reduce the number of `#ifdef`s > needed to compile the agent. If the user attempts to specify a rootfs > on Windows, it will still fail in the containerizer's validation logic. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp > 7e98110af9d105c803518a29cd2e74b7464fcb1e > > Diff: https://reviews.apache.org/r/53623/diff/ > > > Testing > ------- > > make check (CentOS 7) > msbuild ... (Windows 10) > > > Thanks, > > Joseph Wu > >
