> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/launcher/executor.cpp, lines 300-314 > > <https://reviews.apache.org/r/52865/diff/1/?file=1537868#file1537868line300> > > > > This now looks incorrect, we will send a TASK_RUNNING update whenever > > we get a task health message but we may have already transitioned the task > > to TASK_KILLING, right? > > > > Is there something I'm missing that prevents this from sending > > out-of-order status updates now that health messages are generated after > > the task kill is initiated? > > > > Speaking of which, is this a problem more generally? If an external > > kill request arrives but we get a task health message, can we generate a > > TASK_RUNNING here after a TASK_KILLING? > > Gastón Kleiman wrote: > When the health of a task changes, Mesos will currently generate a > {{TASK_RUNNING}} even if it has already generated a {{TASK_KILLING}}, see > https://issues.apache.org/jira/browse/MESOS-6457.
Ben, we've fixed that as part of [MESOS-6457](https://issues.apache.org/jira/browse/MESOS-6457). Dropping the issue. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/#review153583 ----------------------------------------------------------- On Oct. 14, 2016, 12:37 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52865/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 12:37 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > Prior to this patch, HealthChecker would stop performing health > checks after it marks the task for kill. Since tasks' lifecycle > is managed by scheduler-executor, HealthChecker should never stop > health checking on its own. > > > Diffs > ----- > > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52865/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
