> On Nov. 10, 2016, 5:15 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2158 > > <https://reviews.apache.org/r/52295/diff/1/?file=1510689#file1510689line2158> > > > > This test is basically identitcal to > > 'AllocateSharedResourcesMultiFrameworks', can we templatize it?
Moved the two tests into a single parameterized test (HierarchicalAllocatorCommonRoleQuotaTest.AllocateSharedResourcesMultiFrameworks). > On Nov. 10, 2016, 5:15 p.m., Jiang Yan Xu wrote: > > src/tests/persistent_volume_tests.cpp, line 1011 > > <https://reviews.apache.org/r/52295/diff/1/?file=1510691#file1510691line1011> > > > > With the new test helper we now use: > > > > ``` > > Owned<MasterDetector> detector = master.get()->createDetector(); > > Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), > > slaveFlags); > > ``` Since this is a test for master failover, we need to point the detector to the new master, which is accomplished using `StandaloneMasterDetector::appoint()`, which cannot be achieved using `MasterDetector`. So, I kept this test as is. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review152420 ----------------------------------------------------------- On Sept. 27, 2016, 12:39 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52295/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 12:39 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6185 > https://issues.apache.org/jira/browse/MESOS-6185 > > > Repository: mesos > > > Description > ------- > > Tests include the following: > - Allocator tests when dealing with multiple frameworks of the same > role using the same shared volume at the same time. > - Validity of DESTROY shared volume when there are pending tasks > that have been assigned that shared volume. > - Handlng of master failover. > - Sorter tests covering shared resources. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 46553f6d501deb37862dd5ba48be1c114f6e6cb8 > src/tests/master_validation_tests.cpp > 16c5773aa44016f923e00cb348ded6b8c46d4b4b > src/tests/persistent_volume_tests.cpp > 2ab44d11d159162dfcac9d0791b651ed059b8164 > src/tests/sorter_tests.cpp 1f17c011898836ea9159661dde7d544cb0d8ea83 > > Diff: https://reviews.apache.org/r/52295/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
