----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review157627 -----------------------------------------------------------
Ship it! Will commit after I run it. src/tests/sorter_tests.cpp (line 747) <https://reviews.apache.org/r/52295/#comment228234> This should replace line 740? - Jiang Yan Xu On Nov. 18, 2016, 11:49 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52295/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 11:49 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6185 > https://issues.apache.org/jira/browse/MESOS-6185 > > > Repository: mesos > > > Description > ------- > > Tests include the following: > - Allocator tests when dealing with multiple frameworks of the same > role using the same shared volume at the same time. > - Validity of DESTROY shared volume when there are pending tasks > that have been assigned that shared volume. > - Handlng of master failover. > - Sorter tests covering shared resources. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > edd5cea8996d7c616cf9428f0f1c05d70c37c307 > src/tests/master_validation_tests.cpp > f893067859425967654401f3226149268b51cf57 > src/tests/persistent_volume_tests.cpp > 8651b2c5455089041f16d091c90a7e0d948191b8 > src/tests/sorter_tests.cpp 9f48abe65c011acfaf79f3d0d79f1d032fd6a4af > > Diff: https://reviews.apache.org/r/52295/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >