> On Nov. 16, 2016, 10:25 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/windows/error.hpp, lines 108-110 > > <https://reviews.apache.org/r/53474/diff/1/?file=1554344#file1554344line108> > > > > I think we get these inherited from `WindowsErrorBase`, right?
Also need to add `WindowsSocketError(DWORD _code)` for consistency. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53474/#review156121 ----------------------------------------------------------- On Nov. 4, 2016, 11:03 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53474/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 11:03 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6520 > https://issues.apache.org/jira/browse/MESOS-6520 > > > Repository: mesos > > > Description > ------- > > Support explicit error codes in ErrnoError and SocketError. > > > Diffs > ----- > > 3rdparty/stout/include/stout/errorbase.hpp > 96d395d37cdad706c2f23fdd9caeefc2a33e0541 > 3rdparty/stout/include/stout/os/posix/rmdir.hpp > 5657b5a18aaedf842b7b780ea7eada73118788cb > 3rdparty/stout/include/stout/windows/error.hpp > f296b82c47ef5ae36f6e5ee4dd289cb15bd200a6 > 3rdparty/stout/tests/error_tests.cpp > 25b50141dd9bbf163aa816750210b298456740a8 > > Diff: https://reviews.apache.org/r/53474/diff/ > > > Testing > ------- > > make check on Fedora 24 > > > Thanks, > > James Peach > >
