> On Nov. 16, 2016, 10:25 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/posix/rmdir.hpp, lines 57-58 > > <https://reviews.apache.org/r/53474/diff/1/?file=1554343#file1554343line57> > > > > This is great! > > > > It seems like we have more opportunities to update here: > > > > ``` > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > > 166: errno = ENOTCONN; > > 167- return ErrnoError(); > > ``` > > ``` > > 3rdparty/libprocess/src/poll_socket.cpp > > 138-#ifdef __WINDOWS__ > > 139- ::WSASetLastError(opt); > > 140-#else > > 141: errno = opt; > > 142-#endif > > 143- > > 144- return Failure(SocketError("Failed to connect to " + > > stringify(to))); > > ``` > > ``` > > 3rdparty/stout/include/stout/windows/os.hpp > > 254: errno = ENOSYS; > > 255- return ErrnoError( > > 261: errno = ENOSYS; > > 262- return ErrnoError( > > 294: errno = ECHILD; > > 295- return WindowsError( > > 305: errno = ECHILD; > > 306- return WindowsError( > > 324: errno = ECHILD; > > 325- return WindowsError( > > ``` > > ``` > > 3rdparty/stout/include/stout/os/windows/su.hpp > > 55: SetLastError(ERROR_NOT_SUPPORTED); > > 56- return WindowsError(); > > ``` > > ``` > > 3rdparty/stout/include/stout/windows/fs.hpp > > 122: ::SetLastError(error); > > 123- return WindowsError( > > 124- "'fs::list': 'FindNextFile' failed when searching for files > > with " > > 125- "'pattern '" + pattern + "'"); > > ``` > > Michael Park wrote: > Ah, I see that the first two `libevent_ssl_socket.cpp` and > `poll_socket.cpp` are covered by https://reviews.apache.org/r/53475/.
The Windows implementation of `os::waitpid` deliberately sets `errno` in an attempt to be compatible with the the POSIX version. Callers assume that it will set `errno`. I think it is best to leave this alone for now. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53474/#review156121 ----------------------------------------------------------- On Nov. 4, 2016, 11:03 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53474/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 11:03 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6520 > https://issues.apache.org/jira/browse/MESOS-6520 > > > Repository: mesos > > > Description > ------- > > Support explicit error codes in ErrnoError and SocketError. > > > Diffs > ----- > > 3rdparty/stout/include/stout/errorbase.hpp > 96d395d37cdad706c2f23fdd9caeefc2a33e0541 > 3rdparty/stout/include/stout/os/posix/rmdir.hpp > 5657b5a18aaedf842b7b780ea7eada73118788cb > 3rdparty/stout/include/stout/windows/error.hpp > f296b82c47ef5ae36f6e5ee4dd289cb15bd200a6 > 3rdparty/stout/tests/error_tests.cpp > 25b50141dd9bbf163aa816750210b298456740a8 > > Diff: https://reviews.apache.org/r/53474/diff/ > > > Testing > ------- > > make check on Fedora 24 > > > Thanks, > > James Peach > >
