> On Nov. 22, 2016, 6:18 p.m., Gastón Kleiman wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 3972-3974 > > <https://reviews.apache.org/r/53950/diff/2/?file=1568627#file1568627line3972> > > > > Why is this done in a different way than in the other file? > > > > As far as I can see, `testPort_.get()` will abort if there is an error.
In the end all these styles are equivalent, with above variant being marginally more verbose. Using the simplified approach to immediately `get` the value now like elsewhere. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156589 ----------------------------------------------------------- On Nov. 22, 2016, 8:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53950/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 8:49 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-6618 > https://issues.apache.org/jira/browse/MESOS-6618 > > > Repository: mesos > > > Description > ------- > > Avoided hardcoding ports in some tests. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 > src/tests/health_check_tests.cpp 2c7022a1210ade6d7eb594c4f8934f2bdb2aee35 > > Diff: https://reviews.apache.org/r/53950/diff/ > > > Testing > ------- > > make check (SSL build OS X clang trunk w/ optimizations; default build > ubuntu-14.04 gcc-4.8.4 w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
