----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review156819 -----------------------------------------------------------
Fix it, then Ship it! docs/nested-container-and-task-group.md (line 126) <https://reviews.apache.org/r/54013/#comment227134> s/contaienr/container/ docs/nested-container-and-task-group.md (line 147) <https://reviews.apache.org/r/54013/#comment227135> s/guarantee/guarantees/ docs/nested-container-and-task-group.md (line 166) <https://reviews.apache.org/r/54013/#comment227136> Indent, it seems a space is missed here. docs/nested-container-and-task-group.md (line 209) <https://reviews.apache.org/r/54013/#comment227138> Currently we only support a single level of container nesting, right? If so, then I think we may need to mention this limitation here, and also mention we will support multiple level of container netsting in the section of `Future Work`. docs/nested-container-and-task-group.md (line 213) <https://reviews.apache.org/r/54013/#comment227137> I see here you have illustrated `NESTED_CONTAINER_LAUNCH` and `NESTED_CONTAINER_WAIT`, do you want to illustrate `NESTED_CONTAINER_KILL` too? docs/nested-container-and-task-group.md (line 297) <https://reviews.apache.org/r/54013/#comment227139> Does this refer to multiple level of container nesting or something else? - Qian Zhang On Nov. 23, 2016, 12:23 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54013/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 12:23 p.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-6335 > https://issues.apache.org/jira/browse/MESOS-6335 > > > Repository: mesos > > > Description > ------- > > Added user doc for nested container and task group. > > > Diffs > ----- > > docs/nested-container-and-task-group.md PRE-CREATION > > Diff: https://reviews.apache.org/r/54013/diff/ > > > Testing > ------- > > Tested by gist view. Here is the link: > > https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md > > > Thanks, > > Gilbert Song > >
