> On Nov. 24, 2016, 2:41 p.m., Qian Zhang wrote: > > docs/nested-container-and-task-group.md, line 209 > > <https://reviews.apache.org/r/54013/diff/1/?file=1568968#file1568968line209> > > > > Currently we only support a single level of container nesting, right? > > If so, then I think we may need to mention this limitation here, and also > > mention we will support multiple level of container netsting in the section > > of `Future Work`. > > Gilbert Song wrote: > We already supported the multi-level nested container. We have a simple > unit test `ROOT_CGROUPS_LaunchNestedThreeLevels` for three-level nested. > Technically, arbitrary level nested up to 32 should work.
Thanks Gilbert for the clarification! I think the following code confused me: https://github.com/apache/mesos/blob/1.1.0/src/slave/http.cpp#L1933:L1934 Now I understand we do support multi-level nested container, but the nested container can only be created level by level rather than across levels. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54013/#review156819 ----------------------------------------------------------- On Nov. 25, 2016, 4:36 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54013/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2016, 4:36 p.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian > Zhang, and Vinod Kone. > > > Bugs: MESOS-6335 > https://issues.apache.org/jira/browse/MESOS-6335 > > > Repository: mesos > > > Description > ------- > > Added user doc for nested container and task group. > > > Diffs > ----- > > docs/nested-container-and-task-group.md PRE-CREATION > > Diff: https://reviews.apache.org/r/54013/diff/ > > > Testing > ------- > > Tested by gist view. Here is the link: > > https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md > > > Thanks, > > Gilbert Song > >
