> On Nov. 18, 2016, 11:56 a.m., Gastón Kleiman wrote: > > src/examples/persistent_volume_framework.cpp, line 150 > > <https://reviews.apache.org/r/45962/diff/21/?file=1566657#file1566657line150> > > > > Would it make sense to add the `shared-vol` prefix to the shard name in > > order to make debugging/troubleshooting easier?
Yes, agreed. Updated. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156293 ----------------------------------------------------------- On Nov. 29, 2016, 12:25 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45962/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 12:25 a.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Updated a persistent volume test framework to include shared volumes. > > > Diffs > ----- > > src/examples/persistent_volume_framework.cpp > 9d45bb496c4cf378af429b5aa970bf81450e482a > > Diff: https://reviews.apache.org/r/45962/diff/ > > > Testing > ------- > > New test framework for shared resources added. > Tests successful. > > > Thanks, > > Anindya Sinha > >