> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`?
+1, thanks for the helpful suggestion Jie. We were debating what to call this anyway. :) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158030 ----------------------------------------------------------- On Dec. 5, 2016, 5:38 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54335/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 5:38 p.m.) > > > Review request for mesos and Alex Clemmer. > > > Bugs: MESOS-6677 > https://issues.apache.org/jira/browse/MESOS-6677 > > > Repository: mesos > > > Description > ------- > > Returns `/var` on POSIX and (usually) `C:\ProgramData` on Windows. > Uses Windows API to look up correct location for persistent, > app-local variable data. Returns standard location on POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > c37e64db662ba3cee83d2f55de0f9d71ad72c038 > 3rdparty/stout/include/stout/windows/os.hpp > de9b04ad82443038a0f4408bc72cae1540a1beaf > > Diff: https://reviews.apache.org/r/54335/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
