----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54361/#review158161 -----------------------------------------------------------
src/tests/master_tests.cpp (line 4995) <https://reviews.apache.org/r/54361/#comment228912> This will invoke `removeFramework`, shall we make also add some logic to test the `removeFramework` here and deprecate patch https://reviews.apache.org/r/54363 ? As I saw that https://reviews.apache.org/r/54363 almost have same code as this test. We can probably rename this as `AddAndRemoveFrameworkWithMultiRoles`? - Guangya Liu On 十二月 6, 2016, 1:58 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54361/ > ----------------------------------------------------------- > > (Updated 十二月 6, 2016, 1:58 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6684 > https://issues.apache.org/jira/browse/MESOS-6684 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure roles from multi-role framework are added. > > > Diffs > ----- > > src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 > > Diff: https://reviews.apache.org/r/54361/diff/ > > > Testing > ------- > > make > make check GTEST_FILTER="MasterTest.AddFrameworkWithMultipleRoles" > make check > > > Thanks, > > Jay Guo > >
