----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54610/#review158733 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Dec. 9, 2016, 1:30 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54610/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 1:30 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Review #54555 removed `using std::map, std::string, std::vector` > from `windows/subprocess.hpp` but did not add the `std::` > qualification to their uses. > > This commit fixes the Windows build break by qualifying > the uses appropriately, which is the same approach originally > taken in the breaking commit for `posix/subprocess.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/windows/subprocess.hpp > ae684ffab16262af990afdf47b37168ef16565e4 > > Diff: https://reviews.apache.org/r/54610/diff/ > > > Testing > ------- > > make on Linux, no error (as expected). > msbuild on Windows, no error. > > > Thanks, > > Andrew Schwartzmeyer > >
