> On Dec. 11, 2016, 1:24 p.m., Adam B wrote: > > src/slave/http.cpp, line 1833 > > <https://reviews.apache.org/r/54538/diff/2/?file=1580456#file1580456line1833> > > > > double-underscore? Do we just skip over `_containers()`? I suppose > > that's part of `/containers`?
pretty much so. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158795 ----------------------------------------------------------- On Dec. 9, 2016, 4:33 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54538/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 4:33 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Enables fine grained authorization for the v1 API call GET_CONTAINERS. > > > Diffs > ----- > > src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d > src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17 > > Diff: https://reviews.apache.org/r/54538/diff/ > > > Testing > ------- > > ** Needs more testing ** > > make check > > > Thanks, > > Alexander Rojas > >
