----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158661 -----------------------------------------------------------
src/slave/http.cpp (line 1826) <https://reviews.apache.org/r/54538/#comment229458> VIEW_CONTAINER src/slave/http.cpp (line 1831) <https://reviews.apache.org/r/54538/#comment229459> No `[=]`, please? src/slave/slave.hpp (lines 552 - 553) <https://reviews.apache.org/r/54538/#comment229460> Shouldn't we add this fine-grained authz to the /containers endpoint as well (currently protected by coarse-grained GET_ENDPOINT authz)? - Adam B On Dec. 8, 2016, 9:33 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54538/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 9:33 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Enables fine grained authorization for the v1 API call GET_CONTAINERS. > > > Diffs > ----- > > src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d > src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17 > > Diff: https://reviews.apache.org/r/54538/diff/ > > > Testing > ------- > > ** Needs more testing ** > > make check > > > Thanks, > > Alexander Rojas > >
