> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/source/layouts/basic.erb, line 79 > > <https://reviews.apache.org/r/52064/diff/1/?file=1503010#file1503010line79> > > > > We need to make sure the style of verson selection here to match the > > breadcrumb above. > > > > ``` > > <div class="dropdown"> > > </div> > > ``` > > > > Another options are > > > > * we put it in the left panel. Like what tensorflow document do. > > https://www.tensorflow.org/versions/r0.10/get_started/index.html > > * we list all available version in a separate page. Like what spark > > document do. http://spark.apache.org/documentation.html > > Tim Anderegg wrote: > I originally had the version in the left panel, but it seemed a bit > awkwardly placed there, and it seemed to me putting it in the breadcrumbs was > more natural (in Tensorflow's it makes sense, as the left panel is a > navigation menu). I think it's best to have the version dropdown accessible > on each page rather than a separate page, as that is more convenient for > users. I'll try cleaning up the style to match and we can see how that looks.
I updated the style here to match the navigration pane better, I think this is the best approach but let me know what you think. - Tim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150674 ----------------------------------------------------------- On Dec. 12, 2016, 10:03 p.m., Tim Anderegg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52064/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 10:03 p.m.) > > > Review request for mesos, haosdent huang and Vinod Kone. > > > Bugs: MESOS-3011 > https://issues.apache.org/jira/browse/MESOS-3011 > > > Repository: mesos > > > Description > ------- > > Support for multiple versions of docs. > > > Diffs > ----- > > site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 > site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 > site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf > site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b > site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 > site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 > site/data/releases.yml 755300aa83a1017362129bad256381d10c815609 > site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 > site/source/assets/js/versions.js PRE-CREATION > site/source/layouts/basic.erb 7464e40b619e883daad93c72c3fbdbfbdda8f152 > site/source/layouts/documentation.erb > a91f916a5fb7348b2702c272e7a2059bdf628c66 > site/source/layouts/gettingstarted.erb PRE-CREATION > > Diff: https://reviews.apache.org/r/52064/diff/ > > > Testing > ------- > > Testing was done manually to verify that the documentation was built for each > version of Mesos that is supported (some older versions do not have > compatible documentation). > > > Thanks, > > Tim Anderegg > >
