----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53713/#review159634 -----------------------------------------------------------
3rdparty/stout/include/stout/os/mkdir.hpp (lines 45 - 47) <https://reviews.apache.org/r/53713/#comment230656> On Windows, we need to handle paths like: ``` C:\ C:\foo \foo\bar \?\C:\ \?\C:\foo ``` If we're going to add logic for all these path prefixes, we should consider splitting up `mkdir.hpp` into platform specific files. - Joseph Wu On Nov. 13, 2016, 9:44 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53713/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2016, 9:44 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This change allows the user to use different > path formats. Specialy on Windows will allow to > specify `X:\PATH`, '\\foo\bar\PATH`, `\\?\X:\PATH` > and other valid path. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/mkdir.hpp > fe86864c8b480993c8f052f39b2fd3ece23798da > > Diff: https://reviews.apache.org/r/53713/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >