> On Jan. 22, 2017, 7:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.hpp, lines 149-154 > > <https://reviews.apache.org/r/50871/diff/7/?file=1610398#file1610398line149> > > > > I'd suggest we call this `defaultBackend`. I would try to avoid passing > > `backend` to `Store::create` etc. Let's passing `backend` down in > > `Provisioner::provision` and `Store::get`. This way, we might be able to > > support per rootfs backend in the future. Thoughts? > > Gilbert Song wrote: > The tradeoff is that we need to repeatly run this logic every time we > call `provisioner::provision() and store::get()`. I would suggest we figure > out the `defaultBackend` in `provisioner::create` and pass it all the way to > `store::create()`, `puller::create()` and `metadata_manager::create()` etc. > Then, to support rootfs backend per container in the future, we pass an > `Option<string> backend` in `provisioner::provisioner` and `store::get()`. > > For now, I update the patch depending on your comment and leave a `TODO` > for only figuring out `defaultBackend` once at the very beginning > `provisioner::create()`. > > Gilbert Song wrote: > Basically, I still keep the previous implementation as another local > branch. Please let me know if we should change it back.
Please dismiss my comments above. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review162586 ----------------------------------------------------------- On Jan. 24, 2017, 3:22 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50871/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 3:22 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and > Timothy Chen. > > > Bugs: MESOS-5931 > https://issues.apache.org/jira/browse/MESOS-5931 > > > Repository: mesos > > > Description > ------- > > Select a backend smartly. Currently, the logic is really > simple: > 1. Use overlayfs backend if it exists. > 2. Use aufs backend if the overlayfs does not exists. > 3. Use copy backend of both overlayfs and aufs do not exist. > Please note that the bind backend needs to be specified explicitly > through the agent flag '--image_provisioner_backend' since it > requires the sandbox already existed. > > > Diffs > ----- > > docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801 > src/slave/containerizer/mesos/provisioner/appc/store.hpp > 26cdd2fba142874ab1d3eca61222bb22bfbb2e13 > src/slave/containerizer/mesos/provisioner/appc/store.cpp > e63ae419e24212b887edddeb5cae114cd39b39c8 > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > abb8e7e48422896f207a475661ced0530fc75e68 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 817e30c5d6d6a4b011193e3209301fc3cdf88b06 > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > 395c36b0f6b8f8e037681ec5f2df99e83a7cf155 > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 191f3fc8cd1e0f706b5b1e6afddf856e8d53ae6e > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > bbd6005317bed3fff3d86e2527ca3ead839d49e3 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > cecf34a23329a64fdbce7de4b83827a30975e9a4 > src/slave/containerizer/mesos/provisioner/docker/store.hpp > 1c2b149823e83dc5a3feb0af599d651d1dc05682 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 0a48617d6f9ade928993e1d5205de6486ef657c7 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 519028236305e9c8c1b6cded1919a5dd7ca3dbed > src/slave/containerizer/mesos/provisioner/store.hpp > a312ad953b406aa75506051593dcc1c27cdc93af > src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153 > src/slave/flags.cpp d976fb80b9d1e634ce0ca8e8ad35aa64959a4853 > src/tests/containerizer/provisioner_appc_tests.cpp > 4d4ebba92ae66767903edc7a4f6edd9c6fee2489 > src/tests/containerizer/provisioner_docker_tests.cpp > d9472bb44cde999f95a8a65e6eee13f1f0fc09ed > src/tests/containerizer/store.hpp 5abe3f6d211f1d8f5b2a3da977f5a46f4d13b207 > > Diff: https://reviews.apache.org/r/50871/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >
