----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55971/ -----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park. Bugs: MESOS-6964 https://issues.apache.org/jira/browse/MESOS-6964 Repository: mesos Description ------- With the addition of MULTI_ROLE support, the agent needs to ensure that allocated resources reported to the master have the `Resource.AllocationInfo` set. The approach taken here is to set it only in memory upon recovering tasks and executors. Note that once we allow a framework to modify its roles, we need to update the agent to re-persist the resources with injected allocation info (rather than just setting it in memory). Diffs ----- src/slave/resource_estimators/fixed.cpp 2c1268c3423091c6a419020a3af97255de55db0a src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 Diff: https://reviews.apache.org/r/55971/diff/ Testing ------- The tests pass at the end of this review chain. Thanks, Benjamin Mahler