> On 一月 30, 2017, 1:46 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 5244 > > <https://reviews.apache.org/r/55971/diff/2/?file=1617172#file1617172line5244> > > > > How about include `resources` in the log message? > > Benjamin Mahler wrote: > Hm.. I'm having a hard time seeing how that would be helpful here, any > thoughts?
My intention is having `resources` in the log so that we can know which resources do not allocation info in this framework. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55971/#review163428 ----------------------------------------------------------- On 一月 27, 2017, 12:27 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55971/ > ----------------------------------------------------------- > > (Updated 一月 27, 2017, 12:27 a.m.) > > > Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael > Park. > > > Bugs: MESOS-6964 > https://issues.apache.org/jira/browse/MESOS-6964 > > > Repository: mesos > > > Description > ------- > > With the addition of MULTI_ROLE support, the agent needs to ensure > that allocated resources reported to the master have the > `Resource.AllocationInfo` set. The approach taken here is to set > it only in memory upon recovering tasks and executors. Note that > once we allow a framework to modify its roles, we need to update > the agent to re-persist the resources with injected allocation > info (rather than just setting it in memory). > > > Diffs > ----- > > src/slave/resource_estimators/fixed.cpp > 2c1268c3423091c6a419020a3af97255de55db0a > src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 > > Diff: https://reviews.apache.org/r/55971/diff/ > > > Testing > ------- > > The tests pass at the end of this review chain. > > > Thanks, > > Benjamin Mahler > >
