----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ -----------------------------------------------------------
(Updated Jan. 31, 2017, 1:46 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus Ma, and Jiang Yan Xu. Changes ------- Small fix to batch allocation. Bugs: MESOS-6904 https://issues.apache.org/jira/browse/MESOS-6904 Repository: mesos Description ------- - Triggered allocations dispatch allocate() only if there is no pending allocation in the queue. - Allocation candidates are accumulated and only cleared when enqueued allocations are processed. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp 2cda3e311ce339d82065d68de83e86439fa192ff src/master/allocator/mesos/hierarchical.cpp f471b6848bebae601a7a0509e9c6ad5eab4fa4a2 Diff: https://reviews.apache.org/r/51027/diff/ Testing ------- make check with the filters below Broken tests: - TEST_F(HierarchicalAllocatorTest, SuppressAndReviveOffers), fix in 51028 - TEST_F(HierarchicalAllocatorTest, AllocationRunsMetric), fix in 51028 - TEST_F(HierarchicalAllocatorTest, AllocationRunTimerMetrics), fix in 51028 - TEST_F(HierarchicalAllocatorTest, UpdateWeight), fix in 51028 - TEST_P(HierarchicalAllocator_BENCHMARK_Test, AddAndUpdateSlave), fix in 51028 - TEST_F(HierarchicalAllocatorTest, SmallOfferFilterTimeout), fix in 52534 - TEST_F(OversubscriptionTest, RescindRevocableOfferWithIncreasedRevocable), fix in 51621 Thanks, Jacob Janco