-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54537/
-----------------------------------------------------------
(Updated Feb. 2, 2017, 12:39 a.m.)
Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Shuai
Lin, and Timothy Chen.
Changes
-------
Addressed comments.
Bugs: MESOS-6758
https://issues.apache.org/jira/browse/MESOS-6758
Repository: mesos
Description
-------
This patch implements the support for 'Basic' docker registry
authorization. It is tested by a local authenticated private
registry using 'localhost:443/alpine' docker image.
Please note that the AWS ECS uses Basic authorization but it
does not work yet due to the redirect issue MESOS-5172.
Diffs (updated)
-----
src/uri/fetchers/docker.cpp 5dd7b91a5302067ce150bd632a05eccaf424a8a8
Diff: https://reviews.apache.org/r/54537/diff/
Testing
-------
make check
Tested with local authenticated registry. Please follow the steps below:
1. Start a local private registry and push an image to it.
```
docker run -d -p 443:5000 --restart=always --name registry \
-v `pwd`/auth:/auth \
-e "REGISTRY_AUTH=htpasswd" \
-e "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm" \
-e REGISTRY_AUTH_HTPASSWD_PATH=/auth/htpasswd \
-v `pwd`/certs:/certs \
-e REGISTRY_HTTP_TLS_CERTIFICATE=/certs/localhost.crt \
-e REGISTRY_HTTP_TLS_KEY=/certs/localhost.key \
registry:2
```
(*Note: need to generate TLS certificate file and key first)
Then, push an image to the registry.
```
docker push localhost:443/alpine
```
2. Use `mesos-execute` to test the `localhost:443/alpine` image.
(*Note: need to configure the curl using the curl's default RC file), e.g., in
`~/.curlrc` file:
cacert = "/path/to/cacert.pem"
Thanks,
Gilbert Song
