> On Jan. 27, 2017, 7:13 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 237-241 > > <https://reviews.apache.org/r/55910/diff/1/?file=1614081#file1614081line237> > > > > Just a nit here: It seems a bit strange to me here of getting roles as > > following: > > 1) Construct `frameworks` > > 2) Get related framework info > > 3) Get related framework role > > > > How about keep the logic as before but put the logic of construct of > > `frameworks` to #275 here?
I'm not sure why it would strange to insert the framework before updating the sorters, can you clarify? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55910/#review163235 ----------------------------------------------------------- On Jan. 25, 2017, 2:40 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55910/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 2:40 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Currently, a lof of code in the allocator makes use of the `[]` > operator to access the agents, frameworks and sorters, which > can lead to subtle bugs where insertion was unintended. > > With this change, a few const functions can be marked as such. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 9b66c23f26b37c02ed850c06c4518ea99078b02d > src/master/allocator/mesos/hierarchical.cpp > c2211be7458755aeb91ef078e4bfe92ac474044a > > Diff: https://reviews.apache.org/r/55910/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
