----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164094 -----------------------------------------------------------
Patch looks great! Reviews applied: [56267, 56268, 56269, 56270] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56270/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 4:45 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6296 > https://issues.apache.org/jira/browse/MESOS-6296 > > > Repository: mesos > > > Description > ------- > > If a task fails or is explicitly killed by the scheduler, the > default on termination policy kills the particular task group. > The executor commits suicide when there are no active tasks. > > > Diffs > ----- > > src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 > src/tests/default_executor_tests.cpp > e8e0aa2f0d2508de6db03685c70d1ed9c1da3659 > > Diff: https://reviews.apache.org/r/56270/diff/ > > > Testing > ------- > > make check. Also, modified an existing test to launch/kill multiple task > groups. > > > Thanks, > > Anand Mazumdar > >