> On Feb. 8, 2017, 2:26 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, lines 718-721 > > <https://reviews.apache.org/r/56364/diff/1/?file=1625895#file1625895line718> > > > > This is a good default. But we need a way to toggle this behavior, > > such that the agent's death does not kill child jobs. > > > > i.e. A Windows version of ChildHook::SETSID
I asked Andy to follow up this patch with a different changeset that decouples the life of the executor from the life of the agent. Since the agent already kills all executors when it dies, I think it makes sense to have one set of patches just adding Mesos Containers support to Windows, and one fixing the semantics of a dying Agent. Thoughts? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/#review164619 ----------------------------------------------------------- On Feb. 7, 2017, 2:31 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56364/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 2:31 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6892 > https://issues.apache.org/jira/browse/MESOS-6892 > > > Repository: mesos > > > Description > ------- > > `os::create_job` now returns a `Try<SharedHandle>` instead of a raw > `HANDLE`, forcing ownership of the job object handle onto the caller > of the function. `create_job` requires a `std::string name` for the > job object, which is mapped from a PID using `os::name_job`. > > The assignment of a process to the job object is now done via > `Try<Nothing> os::assign_job(SharedHandle, pid_t)`. > > The equivalent of killing a process tree with job object semantics > is simply to terminate the job object. This is done via > `os::kill_job(SharedHandle)`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > b5172fca96c4151f4b1ebb6d343022558f45fc34 > > Diff: https://reviews.apache.org/r/56364/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
