----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review164677 -----------------------------------------------------------
src/checks/checker.hpp (line 70) <https://reviews.apache.org/r/56208/#comment236446> s/taskID/taskId/ We don't use the name `taskID` anywhere else in Mesos. src/checks/checker.hpp (line 95) <https://reviews.apache.org/r/56208/#comment236447> ditto capitalization of the name. - Gastón Kleiman On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56208/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:56 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > Add support for general checks, i.e. defined by CheckInfo, in > checking library. A general check can be either an command or > an HTTP request. The library performs the requested check at > the specified interval and sends the result to the framework > via a task status update. If the current result is the same as > the previous result, no status update is sent. > > > Diffs > ----- > > src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 > src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00 > > Diff: https://reviews.apache.org/r/56208/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
