> On Feb. 14, 2017, 5:46 p.m., Gastón Kleiman wrote: > > src/checks/checker.cpp, line 219 > > <https://reviews.apache.org/r/56208/diff/5/?file=1628427#file1628427line219> > > > > I think that it'd be useful to log the `taskId` here, since an executor > > might have multiple checkers running at the same time. > > Alexander Rukletsov wrote: > To do this we have to cache `taskId` in the class. Is it worth it?
As per offline discussion, I think that we could move this logging statement to `CheckerProcess::finalize()`. I see the following benefits: 1. It makes the debugging output friendlier =). 2. `CheckerProcess::initialize()` already logs the check configuration, so logging something on termination would be symmetrical. 3. It makes `Checker` a plain and simple wrapper, except maybe for the extra validation in `Checker::create()`. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/#review165521 ----------------------------------------------------------- On Feb. 28, 2017, 11:12 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56208/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 11:12 a.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > Add support for general checks, i.e. defined by CheckInfo, in > checking library. A general check can be either an command or > an HTTP request. The library performs the requested check at > the specified interval and sends the result to the framework > via a task status update. If the current result is the same as > the previous result, no status update is sent. > > > Diffs > ----- > > src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 > src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00 > > Diff: https://reviews.apache.org/r/56208/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
